Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix local deployement and add a new doc page #1181

Merged
merged 3 commits into from
Dec 11, 2024
Merged

Conversation

Girgias
Copy link
Member

@Girgias Girgias commented Dec 5, 2024

This mainly fixes the usage of <?php manual_footer([]); ?> which doesn't pass [].

Split from #1180

And fix HTML to be readable
This page has examples with output to test the interactive code runner
Copy link

github-actions bot commented Dec 5, 2024

🚀 Regression report for commit 850039a is at https://web-php-regression-report-pr-1181.preview.thephp.foundation

Copy link

github-actions bot commented Dec 5, 2024

🚀 Preview for commit 850039a can be found at https://web-php-pr-1181.preview.thephp.foundation

@Girgias
Copy link
Member Author

Girgias commented Dec 10, 2024

@saundefined can you have a look at this PR?

@saundefined
Copy link
Member

@Girgias at first glance, it's nice!

I'll look at (and probably update) the screenshot for the regression bit later, and I guess we can merge it

Copy link
Member

@saundefined saundefined left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks!

@saundefined saundefined merged commit 50202bb into master Dec 11, 2024
5 checks passed
@saundefined saundefined deleted the fix-local-manual branch December 11, 2024 09:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants